Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement secrets rm command #247

Closed
tegefaulkes opened this issue Jul 11, 2024 · 4 comments
Closed

Implement secrets rm command #247

tegefaulkes opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Jul 11, 2024

Specification

The secrets rm command will remove one or more files specified by paths.

  1. Will remove the file at the specified path.
  2. Multiple paths can be specified.
  3. Supports wildcard and globing.
  4. Supports a -r recursive option for deleting directories with contents.
  5. Supports normal and secret paths.

Additional context

Related #32

Tasks

  1. Implement secret rm command.
  2. Supports multiple specified paths.
  3. supports wildcard and globing
  4. supports a -r option to recursively delete directories and their contents.
@tegefaulkes tegefaulkes added the development Standard development label Jul 11, 2024
Copy link

linear bot commented Jul 11, 2024

Copy link
Contributor Author

@aryanj this one comes after the cat command. Ignore tasks 3 and 4 for now. Should be simple to implement since it doesn't require and content streaming.

Copy link
Contributor

@aryanj this one comes after the cat command. Ignore tasks 3 and 4 for now. Should be simple to implement since it doesn't require and content streaming.

The secrets cat command relies on the implementation of streaming file contents via the VaultsSecretsGet handler. It can work without it, but it would need to be changed anyways once that has been implemented. As we still need to put a bit more thought into that, I will be working on this command.

Copy link
Contributor

I don't think we even can implement the -f option, as that option forcefully removes unwritable files, but the vaults don't have any concept of actual file perms, so it will be redundant.

Following this, I will remove -f from spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

2 participants