Split Secrets and Vault Command Tests into Separate Files

[tegefaulkes]

Specification

• tests/bin/secrets/secrets.test.ts (every secrets bin command should have its own test file located in tests/bin/secrets and secrets.test.ts can be removed)
• tests/bin/vaults/vaults.test.ts (every vaults bin command should have its own test file located in tests/bin/vaults and vaults.test.ts can be removed)
• tests/client/rpcVaults.test.ts (every vaults client service handler should have its own test file located in tests/client/service and rpcVaults.test.ts can be removed)
• tests/agent/GRPCClientAgent.test.ts (every vaults agent service handler should have its own test file located in tests/agent/service and all vaults-related tests can be removed from GRPCClientAgent.test.ts)

Additional context

• relates to Introducing vault sharing and the restrictions of pulling and cloning with vault permissions Polykey#266 (comment)
• Relates Introducing vault sharing and the restrictions of pulling and cloning with vault permissions Polykey#266
• Relates CLI and Client & Agent Service test splitting Polykey#311

Tasks

1. Expand out spec and tasklist

[CMCDragonkai]

Came out of MatrixAI/Polykey#266 (comment)

[CMCDragonkai]

Recommend doing this as well:

3. The usage of jest.mock is @/keys/utils should be replaced with the usage of the setupGlobalKeypair utility.

[CMCDragonkai]

The tests will require different NodeIds to work.

[CMCDragonkai]

@emmacasolin is this done as part of MatrixAI/Polykey#374?

[emmacasolin]

Not all of it. I only split the client service tests so the bin tests still need doing. There are also missing tests for some of the client and agent vaults/secrets service handlers, and this might be the case for the bin tests as well.

---

Specifically, the missing tests are for

• vaultsClone (client service)
• vaultsPull (client service)
• vaultsScan (client service)
• vaultsGitInfoPack (agent service)
• vaultsGitPackGet (agent service)
• vaultsScan (agent service)

And although not part of the vaults domain there are also no tests for these (although they might be added in the Testnet Deployment PR?)

• nodesChainDataGet (agent service)
• nodesClosestLocalNodesGet (agent service)
• nodesHolePunchMessageSend (agent service)

[CMCDragonkai]

Ok so those are just missing tests, that's a different issue.

Only the bin tests still need to be split, and once split, this issue can be resolved.

[CMCDragonkai]

Can address this next sprint 23.

[tegefaulkes]

This is quick but also very low priority right now.

[CMCDragonkai]

Can be done during CLI factoring out.

[tegefaulkes]

Vaults tests are the slowest tests on the CI right now. I'm considering working on this sooner rather than later. I also need to look into optimising the vaults code. It is very slow when doing vault operations. Hopefully it's a problem with our code and not isomorphic git.

[CMCDragonkai]

This is moved into PK CLI because only 2 things in the spec are relevant now to the PK CLI since the bin was factored out.

Vaults tests is a separate problem.