fix: addressing review comments

[ci skip]

src/vaults/VaultInternal.ts

@@ -953,12 +953,12 @@ class VaultInternal {
         [
           ["a.txt", 0, 2, 0], // new, untracked
           ["b.txt", 0, 2, 2], // added, staged
-          ["c.txt", 0, 2, 3], // added, staged, with unStaged changes
+          ["c.txt", 0, 2, 3], // added, staged, with unstaged changes
           ["d.txt", 1, 1, 1], // unmodified
-          ["e.txt", 1, 2, 1], // modified, unStaged
+          ["e.txt", 1, 2, 1], // modified, unstaged
           ["f.txt", 1, 2, 2], // modified, staged
-          ["g.txt", 1, 2, 3], // modified, staged, with unStaged changes
-          ["h.txt", 1, 0, 1], // deleted, unStaged
+          ["g.txt", 1, 2, 3], // modified, staged, with unstaged changes
+          ["h.txt", 1, 0, 1], // deleted, unstaged
           ["i.txt", 1, 0, 0], // deleted, staged
         ]
         ```

src/vaults/utils.ts

@@ -55,9 +55,9 @@ async function* readDirRecursively(
   fs,
   dir = '.',
 ): AsyncGenerator<string, void, void> {
-  const dirEntities = await fs.promises.readdir(dir);
-  for (const dirent of dirEntities) {
-    const res = path.join(dir, dirent.toString());
+  const dirEntries = await fs.promises.readdir(dir);
+  for (const dirEntry of dirEntries) {
+    const res = path.join(dir, dirEntry.toString());
     const stat = await fs.promises.stat(res);
     if (stat.isDirectory()) {
       yield* readDirRecursively(fs, res);

tests/vaults/VaultOps.test.ts

@@ -326,7 +326,6 @@ describe('VaultOps', () => {
       );
     });
   });
-  // TODO: fix this up. it's an annoying test
   describe('addSecretDirectory', () => {
     test('adding a directory of 1 secret', async () => {
       const secretDir = await fs.promises.mkdtemp(
@@ -476,7 +475,6 @@ describe('VaultOps', () => {
       expect(secretList).toHaveLength(0);
     });
   });
-  // Not sure if hidden file names are a special case, but I'm keeping the tests just in case
   test('adding hidden files and directories', async () => {
     await vaultOps.addSecret(vault, '.hiddenSecret', 'hidden_contents');
     await vaultOps.mkdir(vault, '.hiddenDir', { recursive: true });