tests: random data can be correct sometimes, fixed tests that failed …

…due to this [ci skip]
MatrixAI · May 24, 2024 · dc72c7c · dc72c7c
1 parent eb2c9fe
commit dc72c7c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/tests/git/http.test.ts b/tests/git/http.test.ts
@@ -150,12 +150,14 @@ describe('Git Http', () => {
       'agent=git/[email protected]',
     ]);
   });
-  test.prop([fc.uint8Array({ minLength: 100 })])(
+  test.prop([fc.uint8Array({ minLength: 100 }).noShrink()])(
     'parsePackRequest handles random data',
     async (data) => {
-      await expect(
-        gitHttp.parsePackRequest([Buffer.from(data)]),
-      ).rejects.toThrow(validationErrors.ErrorParse);
+      const bufferData = Buffer.from(data);
+      fc.pre(!/^[0-9a-f]{4}$/.test(bufferData.subarray(0, 4).toString()))
+      await expect(gitHttp.parsePackRequest([bufferData])).rejects.toThrow(
+        validationErrors.ErrorParse,
+      );
     },
   );
   test('generatePackData', async () => {

diff --git a/tests/git/utils.test.ts b/tests/git/utils.test.ts
@@ -240,7 +240,9 @@ describe('Git utils', () => {
   test.prop([fc.uint8Array({ size: 'medium', minLength: 1 }).noShrink()])(
     'parseRequestLine handles bad data',
     async (randomData) => {
-      expect(() => gitUtils.parseRequestLine(Buffer.from(randomData))).toThrow(
+      const bufferData = Buffer.from(randomData);
+      fc.pre(!/^[0-9a-f]{4}$/.test(bufferData.subarray(0, 4).toString()))
+      expect(() => gitUtils.parseRequestLine(bufferData)).toThrow(
         validationErrors.ErrorParse,
       );
     },