Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with read_abs: Table 11 no longer in 5220.0 #262

Open
KyleHaynes opened this issue Dec 8, 2024 · 5 comments
Open

Issue with read_abs: Table 11 no longer in 5220.0 #262

KyleHaynes opened this issue Dec 8, 2024 · 5 comments
Assignees

Comments

@KyleHaynes
Copy link

KyleHaynes commented Dec 8, 2024

read_abs falls over now that Table 11 is no longer included in this publication 1.

This doesn't seem so much an issue of readabs::read_abs, rather that the ABS haven't updated "https://ausstats.abs.gov.au/servlet/TSSearchServlet?catno=5220.0".

However, it would be nice if read_abs could just warn that the table no longer exists rather than error?

Footnotes

  1. https://www.abs.gov.au/statistics/economy/national-accounts/australian-national-accounts-state-accounts/2023-24-financial-year#data-downloads

@MattCowgill
Copy link
Owner

Hi @KyleHaynes!
Thanks for opening an issue, and apologies for the delayed response.
Can you pls confirm what code is causing an issue - is it when you try to load the entire publication with read_abs("5220.0")?

@KyleHaynes
Copy link
Author

Hey @MattCowgill,

Really sorry about a lack of a regex, bad form on my behalf!

Let me know if you need any further info.

library(readabs)

abs_hdi <- read_abs(
    cat_no = "5220.0",
    tables = "all",
    series_id = NULL,
    path = "c:/temp/",
    metadata = TRUE,
    show_progress_bars = TRUE,
    retain_files = TRUE,
    check_local = TRUE
)

Error message:

# fstcore package v0.9.18
# (OpenMP detected, using 8 threads)
# Initiating curl with CURL_SSL_BACKEND: openssl
# Finding URLs for tables corresponding to ABS catalogue 5220.0
# Attempting to download files from catalogue 5220.0, Australian National Accounts: State Accounts
...
# trying URL 'https://www.abs.gov.au/statistics/economy/national-accounts/australian-national-accounts-state-accounts/latest-release/5220011_annual_agricultural_all_states.xlsx'
# trying URL 'https://www.abs.gov.au/statistics/economy/national-accounts/australian-national-accounts-state-accounts/latest-release/5220001_annual_gross_state_product_all_states.xls'
# Error in FUN(X[[i]], ...) :
#   cannot coerce type 'closure' to vector of type 'character'

Session Info:

sessionInfo()
# R version 4.4.0 (2024-04-24 ucrt)
# Platform: x86_64-w64-mingw32/x64
# Running under: Windows 11 x64 (build 22621)

# Matrix products: default


# locale:
# [1] LC_COLLATE=English_Australia.utf8  LC_CTYPE=English_Australia.utf8    LC_MONETARY=English_Australia.utf8 LC_NUMERIC=C                       LC_TIME=English_Australia.utf8    

# time zone: Australia/Brisbane
# tzcode source: internal

# attached base packages:
# [1] stats     graphics  grDevices datasets  utils     methods   base

# other attached packages:
# [1] fstcore_0.9.18 readabs_0.4.16

# loaded via a namespace (and not attached):
#  [1] vctrs_0.6.5       httr_1.4.7        cli_3.6.3         rlang_1.1.4       stringi_1.8.4     purrr_1.0.2       renv_1.0.9        generics_0.1.3    data.table_1.16.0 jsonlite_1.8.9    glue_1.8.0        hutils_1.8.1      readxl_1.4.3     
# [14] fansi_1.0.6       cellranger_1.1.0  tibble_3.2.1      yaml_2.3.10       lifecycle_1.0.4   compiler_4.4.0    rvest_1.0.4       dplyr_1.1.4       fastmatch_1.1-4   Rcpp_1.0.13       pkgconfig_2.0.3   tidyr_1.3.1       fst_0.9.8        
# [27] R6_2.5.1          tidyselect_1.2.1  utf8_1.2.4        curl_5.2.3        parallel_4.4.0    pillar_1.9.0      magrittr_2.0.3    withr_3.0.1       tools_4.4.0       xml2_1.3.6       

@MattCowgill MattCowgill self-assigned this Jan 25, 2025
@MattCowgill
Copy link
Owner

I think the best way to address this is for the ABS to remove table 11 from the TSD. I'll contact them.

@MattCowgill
Copy link
Owner

& thanks for opening the issue and alerting me to this problem!

@KyleHaynes
Copy link
Author

No worries. Sounds good, Interested in the outcome as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants