Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make draining configurable #81

Open
mschnepf opened this issue Sep 20, 2019 · 2 comments
Open

Feature: Make draining configurable #81

mschnepf opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mschnepf
Copy link
Member

In cases where COBalD reduces the demand below the current supply, TARDIS reduce the number of drones by killing requested but not started drones as well as draining running drones. As a result, no further jobs run on the drones, and the empty drones get shut down. However, by resource providers such as HPC clusters, the number of drones get reduced over time when no further drones are requested. For these resources, it is useful not to drain the allocated resources, so that drones which are partly used could accept further jobs over their requested runtime.

Three draining modes would be useful:

  • no draining: not required drones accept further jobs
  • draining: drone does not accept further jobs (current implementation)
  • forced draining: drone does not accept further jobs and goes directly into DisintegrateState state
@mschnepf mschnepf self-assigned this Sep 20, 2019
@mschnepf mschnepf added the enhancement New feature or request label Sep 20, 2019
@giffels
Copy link
Member

giffels commented Sep 20, 2019

Generally a good idea. This needs potentially also adjustments to COBalD. Assuming COBalD is setting the demand of a resource to 0. The resource is moved from the hatchery to the mortuary, hence it is not considered anymore for calculating allocation and utilisation. Basically, COBalD forgets about it. https://github.com/MatterMiners/cobald/blob/5cf8bdb4ab31fb474cc48130817801c32d3783f7/src/cobald/composite/factory.py#L132

I would suggest to re-activate resource in the mortuary first in case new resources are needed because of growing demands. @maxfischer2781 can you comment about that, please?

@giffels
Copy link
Member

giffels commented Sep 20, 2019

Talking to @maxfischer2781 offline: The newest COBalD version already supports part of it. Resources in the mortuary are accounted for allocation, utilisation and supply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants