Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Border to every Page #691

Closed
Yashkapure06 opened this issue Feb 22, 2024 · 4 comments
Closed

Add Border to every Page #691

Yashkapure06 opened this issue Feb 22, 2024 · 4 comments

Comments

@Yashkapure06
Copy link

We can add styling at the front end by adding a proper border and allowing users to add the design of the borders on every page of the printed pdf.

@Yashkapure06
Copy link
Author

@gregnb can you assign me this task? I will try to add that feature

@MatthewHerbst
Copy link
Owner

Hello. Could you please explain better what you are trying to accomplish that you cannot already do with your own page's styles?

@Yashkapure06
Copy link
Author

@MatthewHerbst actually, when one tries to print a pdf having n number of pages, end user expects something more like does the printed pages have better look and feel or not. Adding a border feature to it will be definitely worth.

Yes, I agree it has border feature but here the case is for n number of pages the border starts from the 1st page and doesnot completes the border for the 1st page and the left and right side border keeps on continuing till end of the page and the border bottom is added at the very last so I think adding the following feature will make this library top-notch and best choice to work with

@MatthewHerbst
Copy link
Owner

Users can already do this though? There's nothing this library needs to do to support this. Just add a border using your own CSS. Each person might want their own border styles, there's no generic way to do this. And many people might not want a border at all. This library doesn't know how many pages you are printing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants