Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result of parsing equation is dependent on order of inputs #114

Open
zvxryb opened this issue May 30, 2015 · 2 comments
Open

Result of parsing equation is dependent on order of inputs #114

zvxryb opened this issue May 30, 2015 · 2 comments
Labels
Milestone

Comments

@zvxryb
Copy link
Contributor

zvxryb commented May 30, 2015

Input Result
CQ('ax*bx + ay*by=0') -(ax*bx + ay*by)
CQ('0=ax*bx + ay*by') ax*bx + ay*by

These are both valid results, but they appear as different expressions which makes unit testing difficult.

@MatthewJA MatthewJA added the bug label May 31, 2015
@bshlgrs
Copy link
Collaborator

bshlgrs commented May 31, 2015

We should probably implement a .equals method on nodes, which checks if their simplified and expanded forms are the same.

@MatthewJA
Copy link
Owner

@zvxryb - This should be a pretty easy fix; I'll put it in the next patch.
@bshlgrs - #112

@MatthewJA MatthewJA modified the milestone: v1.2.3 Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants