Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeAgo() should test smaller durations first #283

Open
JetForMe opened this issue Jul 6, 2019 · 0 comments
Open

timeAgo() should test smaller durations first #283

JetForMe opened this issue Jul 6, 2019 · 0 comments

Comments

@JetForMe
Copy link

JetForMe commented Jul 6, 2019

The implementation of timeAgo() first checks years, then months, then days, etc. This results in a situation where times jump from a few minutes ago to a full day ago. For example, say it's currently 00:25, and you're looking at a time 24 minutes ago. You get, as you would expect, "24 minutes ago". But if you look at a time 26 minutes ago, you get "1 day ago," which is arguably not what you want.

Instead, you want seconds ago to grow to minutes ago to grow to hours ago to grow to days ago, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant