From def008464baae4db89cf94b38649b2b06f50b3ba Mon Sep 17 00:00:00 2001 From: Matthias Beerens <3512339+Matthiee@users.noreply.github.com> Date: Sun, 12 May 2024 19:36:02 +0200 Subject: [PATCH] Update getPipelines to return a set of behaviors --- lib/src/request/pipeline/pipeline_behavior_store.dart | 6 +++--- .../pipeline_behavior/pipeline_behavior_store_test.dart | 4 ++-- test/unit/request/requests_manager_test.dart | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/src/request/pipeline/pipeline_behavior_store.dart b/lib/src/request/pipeline/pipeline_behavior_store.dart index 5e9e9b1..467f2c7 100644 --- a/lib/src/request/pipeline/pipeline_behavior_store.dart +++ b/lib/src/request/pipeline/pipeline_behavior_store.dart @@ -61,16 +61,16 @@ class PipelineBehaviorStore implements PipelineConfigurator { } /// Returns all [PipelineBehavior]'s that match. - List getPipelines( + Set getPipelines( Request request, ) { final requestType = request.runtimeType; final behaviors = _typedBehaviors[requestType]; - return [ + return { if (behaviors != null) ...behaviors, ..._genericBehaviors, - ]; + }; } } diff --git a/test/unit/request/pipeline_behavior/pipeline_behavior_store_test.dart b/test/unit/request/pipeline_behavior/pipeline_behavior_store_test.dart index 0bc2eda..d7723a3 100644 --- a/test/unit/request/pipeline_behavior/pipeline_behavior_store_test.dart +++ b/test/unit/request/pipeline_behavior/pipeline_behavior_store_test.dart @@ -252,14 +252,14 @@ void main() { expect( pipelineBehaviorStore.getPipelines(mockRequest), - [ + { correctBehavior, PipelineBehavior.function(correctBehavior.handle), PipelineBehavior.factory(correctFactory), logBehavior, PipelineBehavior.function(logBehavior.handle), PipelineBehavior.factory(logBehaviorFactory), - ], + }, ); }); }); diff --git a/test/unit/request/requests_manager_test.dart b/test/unit/request/requests_manager_test.dart index 5ddcc8f..0e66af8 100644 --- a/test/unit/request/requests_manager_test.dart +++ b/test/unit/request/requests_manager_test.dart @@ -99,7 +99,7 @@ void main() { .thenReturn(mockRequestHandler); when(() => mockPipelineBehaviorStore.getPipelines(mockRequest)) - .thenReturn([]); + .thenReturn({}); final result = await requestsManager.send(mockRequest); @@ -134,7 +134,7 @@ void main() { }); when(() => mockPipelineBehaviorStore.getPipelines(mockRequest)) - .thenReturn([mockBehavior]); + .thenReturn({mockBehavior}); final result = await requestsManager.send(mockRequest); @@ -166,7 +166,7 @@ void main() { }); when(() => mockPipelineBehaviorStore.getPipelines(mockRequest)) - .thenReturn([mockWrongBehavior]); + .thenReturn({mockWrongBehavior}); await expectLater( () => requestsManager.send(mockRequest),