Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Commas in drawer display text for amounts greater than 1,000 #101

Open
Sleepy-TF opened this issue Apr 18, 2024 · 1 comment
Open
Labels
feature A new feature unconfirmed Has not yet been confirmed

Comments

@Sleepy-TF
Copy link

Description of the feature

In the config for drawer capacity using mod menu it automatically adds a comma, yet the text displays for drawers in game don't show commas, leading to slight confusion and occasionally having to count digits with higher amounts of items.

Something else that came to mind while writing this:
Would also be nice if there was a config option to shorten things to have K after them for thousands, even M for millions if someone is willing to fill a drawer/connect enough drawers to a shadow drawer.

How does it make the mod better?

Would be a nice quality of life feature that lets you understand the amount of items being held within drawers at a glance, especially useful for shadow drawers with numerous drawers/drawers with high tier upgrades connected to them.

@Sleepy-TF Sleepy-TF added feature A new feature unconfirmed Has not yet been confirmed labels Apr 18, 2024
@MattiDragon
Copy link
Owner

This seems like a nice idea, but the implementation might be a bit annoying. Ideally I'd want to use the system locale for formatting, but those tend to include weird characters like non breaking spaces that minecrafts font doesn't support. I'll probably just make it separate with spaces as that's pretty universal, possibly with shortening too. I should also probably look into scaling the text to fix the block at the same time.

As for why the config is different: that's because the gui (besides the layout preview) is handled entirely by YACL and they default to the locale formatting with some fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature unconfirmed Has not yet been confirmed
Projects
None yet
Development

No branches or pull requests

2 participants