Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default values for compress ? #6

Open
nikhase opened this issue Aug 12, 2017 · 2 comments
Open

Set default values for compress ? #6

nikhase opened this issue Aug 12, 2017 · 2 comments

Comments

@nikhase
Copy link
Collaborator

nikhase commented Aug 12, 2017

How is it handled in tsfresh?

@nikhase nikhase changed the title Set default values for compress Set default values for compress ? Aug 12, 2017
@MaxBenChrist
Copy link
Owner

How is it handled in tsfresh?

What do you mean? the settings?

@nikhase
Copy link
Collaborator Author

nikhase commented Aug 14, 2017

I changed my mind, I think there is no need for default settings (for column names, etc). I think, explicit is better than implicit in this case.

See in tsfresh:

def extract_features(timeseries_container, default_fc_parameters=None,
                     kind_to_fc_parameters=None,
                     column_id=None, column_sort=None, column_kind=None, column_value=None,
                     chunksize=defaults.CHUNKSIZE,
                     n_jobs=defaults.N_PROCESSES, show_warnings=defaults.SHOW_WARNINGS,
                     disable_progressbar=defaults.DISABLE_PROGRESSBAR,
                     impute_function=defaults.IMPUTE_FUNCTION,
                     profile=defaults.PROFILING,
                     profiling_filename=defaults.PROFILING_FILENAME,
                     profiling_sorting=defaults.PROFILING_SORTING):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants