Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to make sure the target paths are within the allowed mount directory! #2

Open
Maxwell175 opened this issue Dec 23, 2017 · 1 comment
Labels

Comments

@Maxwell175
Copy link
Owner

Maxwell175 commented Dec 23, 2017

Before executing any of the requests make sure that the target path provided by the client doesn't have any gotchas such as an extra trip to the parent directory of the mount point, or worse the root of the actual server's file system.

Obviously, this shouldn't happen unless there is a serious client-side bug (or the client is actually a malicious attacker).

@Maxwell175
Copy link
Owner Author

I will complete some more extensive testing before completely closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant