Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to zoom properly with other scrollable widgets #12

Open
umuieme opened this issue Mar 18, 2023 · 5 comments
Open

Unable to zoom properly with other scrollable widgets #12

umuieme opened this issue Mar 18, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@umuieme
Copy link

umuieme commented Mar 18, 2023

Describe the bug
When the ZoomOverlay widget is used in a listview or pageview or any other scrollable widget then it's hard for the user to trigger the zoom. I have cloned and run the example app of this repo and it is the same issue. Only pinching in a particular way can trigger the zooming.

To Reproduce
Steps to reproduce the behavior:

  1. Run the example app without any changes
  2. Try to zoom in on the image in the same direction as the scroll widget.

Expected behavior
Users should be able to trigger zoom by pinching with two fingers in any way or any direction.

Screenshots

335810156_5968071163261959_8857538911801045666_n.mp4

Smartphone (please complete the following information):

  • Device: Samsung s22 ultra
  • OS: One UI 5.1 based on android 15
@umuieme umuieme added the bug Something isn't working label Mar 18, 2023
@umuieme
Copy link
Author

umuieme commented Mar 18, 2023

I have created a workaround for this by letting the user control based on the number of touches on the screen. I simply created a callback that sends the number of touches currently on the image. This method has minimum change in the library itself with no changes in implementation and in the same time let the developer control it. This can be achieved without any changes in library but it would be make the life easier.

I can create a PR if you are open for it.

@Mayb3Nots
Copy link
Owner

Hi @umuieme, thanks for taking the time to open this issue. This issue has been known for quite some time and I just didn't have time to tackle it. So yes! the PR would be very much welcome 😁

@umuieme
Copy link
Author

umuieme commented Mar 20, 2023

I have created a PR for this.

#13

@guikfe
Copy link

guikfe commented May 20, 2023

No more updates on that issue?

@umuieme
Copy link
Author

umuieme commented May 20, 2023

@guikfe you can use my fork for the time being if it solves the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants