Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Tank Capacity (and Crystalliser loses progress with an empty tank) #309

Open
wrincewind opened this issue Sep 4, 2022 · 1 comment

Comments

@wrincewind
Copy link
Contributor

wrincewind commented Sep 4, 2022

https://github.com/McJtyMods/DeepResonance/blob/1.18/src/main/java/mcjty/deepresonance/util/Constants.java#L9

the above defines 'number of buckets in a tank' as '10', but the lang file:

https://github.com/McJtyMods/DeepResonance/blob/1.18/src/main/resources/assets/deepresonance/lang/en_us.json#L51

says the tank should hold 16 buckets in it.

Somewhat tangentally, i noticed that the crystalliser takes 6 buckets of liquid to make a crystal - but if it consumes more than that and the tank below runs out, progress resets to 0. (I saw that it was producing another crystal, figured it'd hold at whatever % it got to while i made more fluid, but when i came back, it'd reset. So i don't know if this is intentional behaviour, or a bug, or what.)

UPDATE: the crystalliser is 100% just a visual/gui bug. once i put more liquid crystal in ,it resumed from where it had left off.

@McJty
Copy link
Collaborator

McJty commented Sep 5, 2022

Fixed the tank tooltip. Will check the crystaliser later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants