Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchanted books don't have descriptions and don't work in anvil #448

Open
IdkWhatNameThingyToPut opened this issue Sep 27, 2024 · 5 comments

Comments

@IdkWhatNameThingyToPut
Copy link

The enchantment book is from a mod called Dragon Enchants,

Here is my scipt

[
{
"mob": ["minecraft:pig","minecraft:cow"],
"player": true,
"item": "minecraft:enchanted_book",
"nbt": {
"ench": [
{
"lvl": 3,
"id": 114
}
]
}
}
]

it doesn't seem to work in anvils and with the Enchantment Descriptions mod installed they don't seem to show the descriptions either. I don't know if I'm doing something wrong or if it's bugged, please help ahahah

@McJty
Copy link
Collaborator

McJty commented Sep 27, 2024

I'm assuming this is 1.12 because that's old enchantment notation. I can't really help with that as that's a vanilla problem. You need to figure out the correct NBT for such a book. Maybe the Minecraft wiki has that information although not sure if it still shows info for such an old version

@IdkWhatNameThingyToPut
Copy link
Author

IdkWhatNameThingyToPut commented Sep 27, 2024

I'm assuming this is 1.12 because that's old enchantment notation. I can't really help with that as that's a vanilla problem. You need to figure out the correct NBT for such a book. Maybe the Minecraft wiki has that information although not sure if it still shows info for such an old version

Hi sorry yes I forgot to add that this is in modded minecraft 1.12.2 and to do with the loot.json config file

I've also installed your Fx Control mod and dumped the NBT data while holding a bunch of enchantment books in my hand and this what showed in the chat

Capture

I don't really know what to do from here though D:

@McJty
Copy link
Collaborator

McJty commented Sep 27, 2024

hmm sorry. No clue either. 1.12.2 is too old for me to be honest

@IdkWhatNameThingyToPut
Copy link
Author

It's ok dw it's rlly confused me too and I didn't end up figuring out how to do it but putting enchantments onto tools works still though which is honestly still rlly good and I've also tested getting the same enchantments off of tools with the Disenchanter mod and then putting it onto a minecraft book, and it all works really well the book shows as normal with it's descriptions and everything and can be added to another tool from there with an avil which I did test too and that also works good.

I think I saw that the Disenchanter mod comes with a cheap good recipe too but if someone wanted that even easier to get I guess they could try using the CraftTweaker mod to edit it's recipe, and I haven't tried the "message" feature yet in this mod but I'm guessing that could probably be used to remind players that the disenchanter mod is installed and help get the modded enchantments off of tools.

Anyway you can close this now if you want yep everything seems pretty good tyty very much

@IdkWhatNameThingyToPut
Copy link
Author

Sooo I ended up researching some stuff again and AHEM umm ahahah I'm new to this so nobody laugh at me pls but umm all I had to do was change the "ench" thing in the script to "StoredEnchantments" now everything is working fine

I thought I'd come back and put this here in case it could help anyone in the future

Working example script is:
[
{
"mob": ["minecraft:pig","minecraft:cow", "minecraft:sheep"],
"player": true,
"item": "minecraft:enchanted_book",
"nbt": {
"StoredEnchantments": [
{
"lvl": 3,
"id": 54
}
]
}
}
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants