Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.16.5-1.18 Capabilities on TileEntities never notify that they are unloaded #150

Open
Speiger opened this issue Mar 11, 2022 · 0 comments
Open

1.16.5-1.18 Capabilities on TileEntities never notify that they are unloaded #150

Speiger opened this issue Mar 11, 2022 · 0 comments

Comments

@Speiger
Copy link

Speiger commented Mar 11, 2022

o/
Since 1.14 capabilities are cacheable and TileEntities are expected to notify LazyOptional listeners that they unload.
If they don't do it then you get bugs that machines from other mods might not work.

And I just checked your Code (GenericTileEntity) does not call LazyOptional.invalidate when the TileEntity gets unloaded.
TileEntity.invalidateCaps function exist that is called by all methods that should support it.

Could you fix that please?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Speiger