Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.3 #12

Open
PortableGames opened this issue Dec 16, 2022 · 6 comments
Open

1.19.3 #12

PortableGames opened this issue Dec 16, 2022 · 6 comments

Comments

@PortableGames
Copy link

Update https://github.com/McTsts/mc-core-shaders#hide-sidebar-numbers to 1.19.3

@McTsts
Copy link
Owner

McTsts commented Dec 16, 2022

Did it break?

@PortableGames
Copy link
Author

I'm not sure if it's my launcher's fault. I use a mobile POJAV launcher (opengl 2.1). Anyway, the numbers from the scoreboard haven't disappeared

@PortableGames
Copy link
Author

On pc:
how

@McTsts
Copy link
Owner

McTsts commented Dec 26, 2022

The shader by default only removes a single digit of numbers, adjust the shader as explained in the comments of the file to work for 2 characters.

@ArthurTheEagle
Copy link

Hello McTsts, first of all thank you so much for this wonderful and very much useful library !
Unfortunately, and as of 1.20.1, the shader used to remove de text shadow does not seem to have any effect, could I be doing something wrong ?

@ItzAaronUwU
Copy link

#version 150

#moj_import <fog.glsl>

in vec3 Position;
in vec4 Color;
in vec2 UV0;
in ivec2 UV2;

uniform sampler2D Sampler2;

uniform mat4 ModelViewMat;
uniform mat4 ProjMat;
uniform mat3 IViewRotMat;
uniform int FogShape;

uniform vec2 ScreenSize;

out float vertexDistance;
out vec4 vertexColor;
out vec2 texCoord0;

void main() {
    gl_Position = ProjMat * ModelViewMat * vec4(Position, 1.0);

    vertexDistance = fog_distance(ModelViewMat, IViewRotMat * Position, FogShape);
    vertexColor = Color * texelFetch(Sampler2, UV2 / 16, 0);
    texCoord0 = UV0;
    
	// delete sidebar numbers
	if(Position.z == 0.0 &&
		gl_Position.x >= 0.95 && gl_Position.y >= -0.35 &&
		vertexColor.g == 84.0/255.0 && vertexColor.g == 84.0/255.0 && vertexColor.r == 252.0/255.0 &&
		gl_VertexID <= 4
	) gl_Position = ProjMat * ModelViewMat * vec4(ScreenSize + 100.0, 0.0, 0.0); 
}

This works for me.
Had to change the gl_VertexID <= 3 to gl_VertexID <= 4
and gl_Position.x >= 0.94 to gl_Position.x >= 0.95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants