Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

[MAT-6046] Replace TGT/ST with UMLS API Key in VSAC Requests - FHIR #2170

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

Remove TGT/ST related methods.

Replace TGT session storage with API Key.

Replace TGT/ST related parameters with API Key.

Consider a UMLS session invalid when an authenticated request (using the API Key) returns 401 instead of checking for TGT/ST generation, or if unable to retrieve a small valueset.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner September 11, 2023 18:58
…ey. Replace TGT/ST related parameters with API Key. Consider a UMLS session invalid when an authenticated request (using the API Key) returns 401 instead of checking for TGT/ST generation.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6046-update-vsac-connection-fhir branch from ff3d720 to 94da7b9 Compare September 11, 2023 19:38
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2170 (d00b0b6) into bonnie-on-fhir (e0884c6) will increase coverage by 1.52%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           bonnie-on-fhir    #2170      +/-   ##
==================================================
+ Coverage           69.32%   70.85%   +1.52%     
==================================================
  Files                 196      140      -56     
  Lines               10657     8351    -2306     
  Branches             1270     1270              
==================================================
- Hits                 7388     5917    -1471     
+ Misses               2665     1830     -835     
  Partials              604      604              

see 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0884c6...d00b0b6. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit da9aaf2 into bonnie-on-fhir Sep 14, 2023
21 of 23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants