Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Remove VSAC Cred Timeout #2175

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Sep 14, 2023

Removing the VSAC TGT timeout check from the import dialog.

With the removal of the TGT, VSAC Creds no longer expire, thus making the timeout unnecessary.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jkotanchik-SB jkotanchik-SB self-assigned this Sep 14, 2023
@jkotanchik-SB jkotanchik-SB requested a review from a team September 14, 2023 20:39
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2175 (2a8b9e3) into bonnie-prior (d5d80c6) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           bonnie-prior    #2175      +/-   ##
================================================
+ Coverage         73.48%   73.50%   +0.02%     
================================================
  Files                83       83              
  Lines              5954     5952       -2     
  Branches            809      809              
================================================
  Hits               4375     4375              
+ Misses             1263     1261       -2     
  Partials            316      316              
Files Changed Coverage Δ
...ts/javascripts/views/import_measure_view.js.coffee 76.28% <ø> (+0.96%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d80c6...2a8b9e3. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit 13d8859 into bonnie-prior Sep 14, 2023
18 of 20 checks passed
@jkotanchik-SB jkotanchik-SB deleted the bugfix/remove-vsac-cred-timeout-prior branch September 14, 2023 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants