Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected line chart behaviour #92

Open
ralight opened this issue Apr 11, 2018 · 2 comments
Open

Unexpected line chart behaviour #92

ralight opened this issue Apr 11, 2018 · 2 comments

Comments

@ralight
Copy link

ralight commented Apr 11, 2018

Total open PRs, earlier this evening:
before
And after I've closed some PRs:
after

The whole right hand side of the graph has shifted downwards. My understanding is that the line chart is showing me the number of open pull requests I had in a given month. If that's the case, closing PRs now shouldn't affect the results for last month. Same thing is happening with the issues line chart.

@ralight
Copy link
Author

ralight commented Apr 11, 2018

There is related behaviour on the PRs open and closed this month which makes me suspect it is my expectation of what the graph is showing is wrong.

I think:

Open/close state for a given month

Looks like:

How many were closed in a given month, also how many are currently still open from that month.

That kind of makes sense for the bar charts, you have a log of your activity (closed) plus an indicator of the backlog and how many old PRs there are. A bit confusing without some explanation though.

@stuartlangridge
Copy link
Collaborator

Yup. The issue is that knowing how many were opened in a given month isn't really as helpful as knowing how many are still open, if you see what I mean. The goal is to do the intuitive thing rather than necessarily the mathematically correct thing. This may need some tweaking, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants