Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are there so many methods, and even some file have only one method #59

Open
Czshippee opened this issue Apr 22, 2022 · 2 comments
Open

Comments

@Czshippee
Copy link

Why make the code so complicated? I just want to see how you use transforms to augment the image. From the dataset file, I jumped 6 pages and haven't seen the final code so far. . . . .

@Czshippee
Copy link
Author

You have a function called '_build_transform' in class common, and inside the function there is only one line which is return 'build_transform'. After I jump tp that page, there are only one function in this file, and I can see you only call this function once, so why you just put the code inside the '_build_transform '.

@DarthThomas
Copy link
Contributor

DarthThomas commented Apr 22, 2022

Why make the code so complicated? I just want to see how you use transforms to augment the image. From the dataset file, I jumped 6 pages and haven't seen the final code so far. . . . .

Hi,

Thanks for your interest in our Vedaseg.

Our design makes it easier to develop and use in our sense.

You should look at transformes instead of dataset.

FYI, we are building transforms based on albumentations

For the '_build_transform' part you mentioned, you are trapped in our mechanism design. Those designs makes it easier for customization based on your own needs. With those 'extra codes', you can define your experiments by only change the config file instead of changing actual code. You will see it when you see the whole picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants