llvm-objcopy: Disable huge sec offset #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazs-github
changed the base branch from
mtk/nanomips-llvm16
to
nanomips-llvm16
djtodoro
force-pushed
the
syrmia/objcopy-disable-huge-sec-offset
branch
from
fde7ae0
to
b39e492
Compare
|
@farazs-github Thanks for the feedback! |
|
I've gotten some comments on the upstream PR. I will apply them here when it is ready/merged there. |
By default, GNU objcopy issues a warning for large offsets in ELF files. To align with this behavior, we introduce an option to define a maximum file offset for a section. This allows us to skip creating excessively large files by specifying a threshold beyond which the file offset will trigger an error.
djtodoro
force-pushed
the
syrmia/objcopy-disable-huge-sec-offset
branch
from
b39e492
to
1f3a427
Compare
|
I have incorporated all comments from reviewers from the upstream PR. They are happy with implementation, but there is ongoing discussion about the option being accepted at first place. |
|
Merged internally (review process also done on upstream - the implementation is OK, but there is a discussion if we even want this option in mainline). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match GNU objcopy's behavior.
This is controlled by an option.