Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo: Clarify ambiguous or outdated information (comments, license etc.) #50

Open
Olf0 opened this issue May 25, 2024 · 4 comments
Open

Comments

@Olf0
Copy link
Member

Olf0 commented May 25, 2024

Two unrelated questions, I stumbled over when I worked with the spec file and which I am willing to fix when I have some time:

  1. You stopped using Spectacle for generating the spec file for the SailfishOS builds, correct?
  2. Which licence is exactly meant? It is stated consistently GPLv2.1, but no such license exists: There is the GPLv2.0 and the LGPLv2.1, see spdx.org/licenses or opensource.org/licenses. As the full license text is missing, I cannot tell what the intended license is.
    If you do not remember, I suggest using the LGPLv2.1 (i.e., interpret that the "L" is missing instead of the "1" being wrong), because it still ensures that all assets (code etc.) of MeeCast must stay Open Source licensed under this license, but allows proprietary software to directly use these assets (e.g. libraries, icons etc.); in short, it allows a broader reuse of the work created here.
    Additionally I wanted to check if GPLv2.0-only / LGPLv2.1-only or GPLv2.0+ / LGPLv2.1+ was intended, because the GPL3-family of licenses differs significantly from the GPL2-family to an extent that they are legally incompatible with each other: With the + ("or any later version") everybody can choose to reuse the assets of MeeCast under any later license of that type (GPL, LGPL, AGPL) the FSF publishes and the GPL3-family imposes restrictions which practically make using such licensed software impossible in scenarios where the device owner is not the user of that device (which is why Jolla, Google etc. avoid them like hell). The classic example are devices owned by institutions (companies, governmental offices etc.) which are used by their employees and administrated by the IT-department of the institution. Personally I think the GPL3-family of are unfree licenses, because they practically prevent certain use-cases, which contradicts "freedom #0" as the FSF calls it, which states that "anybody may use this software for any purpose at any time anywhere". Furthermore, nobody knows which changes even newer versions may bring, hence the + ("or any later version") implies arbitrary uncertainty. This is the reason why I always prefer to use a specific license, i.e. -only.

If you @vasvlad provide me with feedback to these two points, I will rectify point 1 with a PR for the sailfishos branch and point 2 with a PR for the master branch (full license text, correct license ID etc.).

@vasvlad
Copy link
Member

vasvlad commented Jun 2, 2024

  1. Yes. I don't currently use Spectacle. I edit the spec file manually. I think this yaml file can be completely removed from source tree.

@vasvlad
Copy link
Member

vasvlad commented Jun 2, 2024

  1. I agree with you about GPL 3 and agree with the suggestion to use LGPLv2.1 in Meecast. Thank you very much for your help.

@Olf0
Copy link
Member Author

Olf0 commented Jun 2, 2024

Thank you for your clarifying both points. I will create two PRs addressing these issues, when I have some time for that.

Olf0 added a commit to Olf0/meecast that referenced this issue Jun 3, 2024
Addresses second point of issue Meecast#50.
vasvlad pushed a commit that referenced this issue Jun 12, 2024
* [LICENSE] Clarify licence: LGPL-2.1-only

Addresses second point of issue #50.

* [LICENSE] Specify different spellings of Vlad's name

* [debian/copyright] Add proper and correct licence

* [rpm/meecast.spec] Specify correct licence by SPDX ID

* [omweather-weather-com-stations-db.yaml] Specify correct licence by SPDX ID

* [omweather-weather-com-stations-db.spec] Specify correct licence by SPDX ID

* [pl_PL.po] Specify correct licence

* [UIConstants.js] Specify (alternate) licence more concisely

* [fi_FI.po] Specify licence more concisely

* [icons_readme.txt] Specify license more concisely

* Update data.h

* Update Makefile.am

* Update es_MX.po

* Update main.cpp

* Update omweather-sources.hpp

* Update copyright

* Update en_GB.po

* Update config.h

* Update meego-main.c

* Update stationlist.h

* Update updatethread.cpp

* Update networkingcontrol.cpp

* Update weather-main.c

* Update databasesqlite.cpp

* Update hash.h

* Update weather-popup.c

* Update omweather-sensor.hpp

* Update qmllayoutitem.h
@Olf0
Copy link
Member Author

Olf0 commented Jun 12, 2024

Part 2 is not finished yet, see PR #51 (comment)

I did not start to work on part 1, but that is by far the less tedious one.

Olf0 added a commit to Olf0/meecast that referenced this issue Jun 12, 2024
vasvlad pushed a commit that referenced this issue Jun 13, 2024
* [rpm/meecast.spec] Fix writing dconf key, license etc.

Addresses issue #50

* [rpm/meecast.spec] Count up release number …

… for all packages whose the spec file entries were altered.

* [rpm/meecast.spec] Delete spectacle's comments, rectify changelog format, …

… add missed `exit 0` to a scriptlet to make it fail-safe, omit superfluous `-n %{name}-%{version}` for `%setup -q` and omit  long superfluous `rm -rf %{buildroot}` in `%install` section.

* [rpm/meecast.spec] Fix two typos in `%changelog`

* [rpm/meecast.spec] Fix `%sailfishos_version` format error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants