Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic resource cleanup #25

Open
roblabla opened this issue Mar 26, 2018 · 1 comment
Open

Panic resource cleanup #25

roblabla opened this issue Mar 26, 2018 · 1 comment

Comments

@roblabla
Copy link
Member

So right now I'm not cleaning up any resource on panic (since we're simply aborting). This is obviously not good. My plan thus far was to rely on the unwinder (#13) to do the job, but maybe that's not such a good idea, as various things still cause aborts:

  • panics during unwinding
  • OOM, and in general most panics in memory management.
@FenrirWolf
Copy link
Member

Unwinding is still a good idea even if it doesn't solve those specific problems, since ideally those situations would be a lot more rare than a typical panic. I'm not sure how you'd go about gracefully recovering from a situation that calls for a true abort though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants