Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings in generated IPC bindings #5

Open
roblabla opened this issue Mar 8, 2018 · 1 comment
Open

Fix compiler warnings in generated IPC bindings #5

roblabla opened this issue Mar 8, 2018 · 1 comment

Comments

@roblabla
Copy link
Member

roblabla commented Mar 8, 2018

Ideally, without muting the errors, but by actually fixing them. It might be hard, but I think it'd be worth it to have nice, readable, idiomatic code.

Some anticipated difficulties:

  • SwIPC methods are in CamelCase, rust wants some snake_casing. Can we do this in a clean way ? I've noticed some function like ForceSetClientPID. Can we easily snake_case those ?
@roblabla
Copy link
Member Author

Most of those have been fixed, only 3 are left, which I expect to be fixed whenever we gain full coverage of the IPC API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roblabla