-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐞]: Failed to generate recipe for #500
Comments
I would suggest allowing a blacklist of items that can appear as output item (e.g. prevent oak_window_pane to be handled) or not throwing an exception but instead logging a smaller message, bonus points if that only happens once per game instance |
I cannot replicate the problem on my side. First, just use:
run the Minecraft and check if there is no error in generating the recipe. Then one of the mods in your modpack is screwing up the generation of the recipe |
Haven't heard from you for a while, is there any news regarding this issue? |
Yeah sorry lots of "no time" right now. I will try to get to it today or tomorrow |
Ok after a long "tomorrow" I finally found time to debug this. This is also requires https://github.com/Fuzss/diagonalwalls . I have this mod list (all of them the newest version): ModList
|
I'll test the modlist on my side and will let u know how it turned out. UPDATE:With the modlist you provided with Hybrid Aquatic and Create, I can't reproduce. I am wondering what mods that require Dawn API, that's just a library mod. |
Can you try with the new list I sent? I had the initial one made from the errors but I could reproduce it with the lower one. Dawn API was just still in the list because I forgot it wasn't needed for any of them. Can still reproduce without.
|
The cause is Diagonal Wall, There is nothing wrong with EveryComp or Moonlight Lib. idk why. This require further investigation. hedge is considered to be a "wall" so Diagonal Wall should have supported that but somehow screw up the generation of recipes via Moonlight Lib. World Preview is not related to this issue. |
I no longer have the issue on my side. Macaw's Fences & Walls (MCF) have been updated to v1.1.2 EveryComp (EC) is also updated to support v1.1.2 but won't support the older version anymore. Can you test on your side with the latest version when Moonlight Lib & EveryComp is out on Curseforge & Modrinth UPDATE:interesting. The theory is the hedge does not have the tags and that may be the cause of why Diagonal Wall screwing up the generation of recipes. the tags for hedge is I decided to test to see if the updated EC and MCF solved this problem. Anyway, this should fix the problem. |
The issue still exists when I run the mod list (updated to the newest versions ofc). And additionally I get a lot of logs like this now
|
I haven't uploaded EveryComp to Curseforge or Modrinth yet. I'll let u know when. this should be fixed in v2.6.62 |
Please let me know if v2.6.62 has fixed the problem. It's out on Curseforge and modrinth |
Haven't heard from you, does the latest version fix this issue? |
Sorry for the delayed answer. The errors with mcw's mods are gone but I still see some with chipped. I will try to make a minimal reproduce for that one |
Nevermind, it also reports that for the other items too.
|
I cannot replicate the problem on my side. I know you are busy and have little times. Try and see if you can disable all of mods with a few mods enabled. so you can enable 1-4 mods a time to load world until you got the error spam. The culprit need to be isolated. One of the mods is somehow screwing up the generation of recipe. |
As listed in my previous message I can reproduce it with just Macaw's Fences, Macaw's Holidays, Diagonal Walls, Diagonal Fences and Everycomp. All of them are in their newest version |
I ran a simple test by actually crafting item/block. The result is I can craft the hedge on my side even with the error in the log. These errors are "false positive". Idk why it happened. The recipe are generated for these hedges. Can you confirm that you can craft the hedge. If you have no problems, then yea. For now, just ignore these errors. This issue should be related to Moonlight lib. I'll talk to MehVahdJukaar. |
Just checking, do you still get the false errors in the logging? |
since there is no replying. will be closing this. |
Before Continuing:
Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
Version
1.20.1
Loader
Fabric
EveryCompat Version
everycomp-1.20-2.6.53
Moonlight Lib Version
moonlight-1.20-2.11.12
Issue with mods
Thats a difficult question. I saw issues with these even tho everything works
Issue Detail
Basically what the title says, the logs gets spammed every time the world generator gets initialized. Since I have "World Preview" installed this happens farirly often
OPTIONAL: Latest.log | Crash-report Attachment
Portion of latest.log
OPTIONAL: To Produce
The text was updated successfully, but these errors were encountered: