Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Some undetected wood types and false positive wood types #767

Open
4 tasks done
FreyrDev opened this issue Jan 10, 2025 · 3 comments
Open
4 tasks done

[🐞]: Some undetected wood types and false positive wood types #767

FreyrDev opened this issue Jan 10, 2025 · 3 comments
Labels
1.21.1-FABRIC Minecraft Version bug Something isn't working

Comments

@FreyrDev
Copy link

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.21.1 - FABRIC

EveryCompat Version

everycomp-1.21-2.8.5-fabric

Moonlight Lib Version

moonlight-1.21-2.17.12-fabric

Issue with mods

  • Blockus
  • My Nether's Delight Refabricated (Probably also affects other versions of /(My)? Nether's Delight (Refabricated)?/)

Issue Detail

As can be seen here, my testing setup currently adds six new full wood sets:

2025-01-09_22 42 07

In order, these are:

  • blockus:white_oak
  • blockus:charred
  • blockus:raw_bamboo
  • gardens_of_the_dead:soulblight
  • gardens_of_the_dead:whistlecane
  • mynethersdelight:powdery

However, when we look at what blocks are added by Every Compat there are only four types:

2025-01-09_22 42 20

In order:

  • gardens_of_the_dead:soulblight
  • gardens_of_the_dead:whistlecane
  • blockus:white_oak
  • blockus:legacy

So there are two problems here:

Firstly, the false positive detection of blockus:legacy as a wood type. Blockus' legacy blocks are a weird addition and I usually disable them anyway, there are only two blocks in this "wood set": those being blockus:legacy_log and blockus:legacy_planks, none of the other things that usually make up a wood set, and they don't even match with each other. This one admittedly isn't that big of a deal given it's possible to disable it in the everycomp-entries.json config.

Secondly, the fact that blockus:charred, blockus:raw_bamboo, and mynethersdelight:powdery get missed completely by Every Compat. Until I saw whistlecane I had initially just assumed that bamboo type woods weren't included, but now I have no idea what's causing powdery wood to get missed; it's using the same naming conventions as whistlecane and vanilla bamboo. For the other two, I assume they're not getting picked up because they don't have their own log blocks despite having every other block in a normal wood set (doors, signs, fences, etc.).

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

@FreyrDev FreyrDev added the bug Something isn't working label Jan 10, 2025
@github-actions github-actions bot added the 1.21.1-FABRIC Minecraft Version label Jan 10, 2025
@Xelbayria
Copy link
Collaborator

Xelbayria commented Jan 10, 2025

  1. Whistlecane was manually added to WoodType. it's a type which is similar to "sugarcane".
  2. Can you check the undetected woodType having "bass" sound?
  3. the block, blockus:legacy only have log and planks, that's it, correct?

@FreyrDev
Copy link
Author

All three of charred, raw bamboo, and powdery wood do use bass yes. And yeah legacy only has those two blocks.

@Xelbayria
Copy link
Collaborator

Alright,

First,
The following undetected woodTypes are:

  • blockus:charred
  • blockus:raw_bamboo
  • mynethersdelight:powdery

I'll need the Ids of log and planks of these 3 woodTypes.
the powdery, it would be better if it has a block that can be treated as "log" and a planks as planks. Same with raw_bamboo. Once i got the info, I'll add them to Moonlight

Second,
blockus:legacy is good enough for most blocks from supported mods that only require log or planks. but not stripped_log, and other children (trapdoor, door, so on).

Can you clarify regarding blockus:legacy below:

they don't even match with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1-FABRIC Minecraft Version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants