Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] Incompatibility with VoxelMap #12

Closed
xJon opened this issue Jul 31, 2022 · 8 comments
Closed

[1.12.2] Incompatibility with VoxelMap #12

xJon opened this issue Jul 31, 2022 · 8 comments

Comments

@xJon
Copy link

xJon commented Jul 31, 2022

Describe the bug
As the title states, random crash upon singleplayer world load.

To Reproduce
Not sure how to reproduce, but figured it might still be useful to share!

Versions
RenderLib: 1.1.1
Forge: 14.23.5.2860
Minecraft: 1.12.2
Other mods (necessary to reproduce the bug): Unknown

Log File
https://mclo.gs/gQ4LG1y

@xJon xJon added the bug label Jul 31, 2022
@xJon xJon changed the title [1.12.2] Random crash upon world load [1.12.2] Random ConcurrentModificationException upon world load Jul 31, 2022
@xJon
Copy link
Author

xJon commented Jul 31, 2022

This might be related to GregTechCE/GregTech#1256? and also perhaps supposed to be fixed by LoliASM (which was included) thanks to LoliKingdom/LoliASM@d7fa000, alas the crash still occurred.

@xJon

This comment was marked as outdated.

@Meldexun
Copy link
Owner

This is not related to the GregTech issue.

Old EntityCulling versions are unsupported.

@Meldexun
Copy link
Owner

You can try to reproduce the issue with this version.
RenderLib-1.12.2-1.1.4-dev1.jar.zip

@xJon
Copy link
Author

xJon commented Aug 10, 2022

Got a crash with it, seems to be due to VoxelMap: https://mclo.gs/e0Ywiqv

@Meldexun
Copy link
Owner

That's a VoxelMap issue. Placing blocks is not threadsafe.

@xJon
Copy link
Author

xJon commented Aug 11, 2022

I got a couple more crashes not mentioning VoxelMap:
https://mclo.gs/80HuT6r
https://mclo.gs/ZyTR3sP
Probably still are caused due to it, I will try reaching out to the VoxelMap author although they don't seem to be active.
(I can also confirm the game does not crash in the same way when Entity Culling / RenderLib are not installed)
Edit: this appears in the log before the crash: https://mclo.gs/1Tw40yt

@xJon xJon changed the title [1.12.2] Random ConcurrentModificationException upon world load [1.12.2] Incompatibility with VoxelMap Aug 26, 2022
@xJon
Copy link
Author

xJon commented Sep 19, 2022

This is resolved by using the latest version of VoxelMapFixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants