Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some message sizes are not compatible with some tests #59

Open
blochl opened this issue Jan 14, 2024 · 0 comments
Open

Some message sizes are not compatible with some tests #59

blochl opened this issue Jan 14, 2024 · 0 comments
Assignees

Comments

@blochl
Copy link
Collaborator

blochl commented Jan 14, 2024

Now there is a default message size of 65536 for BW tests, and 2 for latency tests. This fails some tests, as for example, UC requires a message size not larger than the MTU.

I suggest having only one message size array (for cases when a user who knows what they do to be able to set manually) and for the 'usual' cases leave the default handling to perftest itself, which already has the knowledge which default is best for which test. ngc_multinode_perf does not need to have a duplication of this logic, and this way we avoid having 3 different arrays (at least!): for BW (non-UC), BW (UC), and lat tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants