Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeltanoLabs/tap-facebook vs. singer-io/tap-facebook #68

Closed
robg-eb opened this issue May 17, 2023 · 4 comments
Closed

MeltanoLabs/tap-facebook vs. singer-io/tap-facebook #68

robg-eb opened this issue May 17, 2023 · 4 comments

Comments

@robg-eb
Copy link

robg-eb commented May 17, 2023

I was wondering if, in the README.md, an outline could be provided of the goals/purpose of this (relatively new) MelantoLabs/tap-facebook Tap, in comparison/contrast to singer-io/tap-facebook. The latter has been around for much longer, but at a high level it seems they both aim to produce streams of Ads, Ad Insights, and other Facebook Ad data. Are there some particular use cases where one is preferable over the other? Is there a reason a decision was made to start fresh with MeltanoLabs/tap-facebook rather than attempt to iterate/tweak the singer-io/tap-facebook?

@edgarrmondragon
Copy link
Member

Hello @robg-eb!

Is there a reason a decision was made to start fresh with MeltanoLabs/tap-facebook rather than attempt to iterate/tweak the singer-io/tap-facebook?

We decided to build from scratch on top of the Singer SDK, which comes with desirable features that would've been harder to port to the singer-io implementation, such as streams maps.

This implementation will also be receiving more support from the Meltano team for Cloud customers.

cc @tayloramurphy

@tayloramurphy
Copy link
Collaborator

tayloramurphy commented May 18, 2023

@robg-eb I don't think we'll be putting the reasoning into the README for this particular connector. I would echo what Edgar said though - we can offer more features and support if the connector is built on the SDK.

I think we could add an FAQ section to the Hub around why we're building SDK-based connectors generally though. Would something like that be useful? https://hub.meltano.com/extractors/tap-facebook

@robg-eb
Copy link
Author

robg-eb commented May 18, 2023

@tayloramurphy - Yes, that would be great! It's hard currently to know which version of a tap to use when there are multiple 'official' ones - In this case, the singer-io version for Facebook has 100+ stars, and has been around for several years (but also has 30+ open issues), while this meltanolabs one is hot off the presses, and thus might not be as 'battle tested' just yet.

@tayloramurphy
Copy link
Collaborator

@robg-eb I'll open a new issue around this. We do have an FAQ section in https://hub.meltano.com/tap-target-maintenance#faqs but it doesn't directly answer you question.

We could move many of those to a separate FAQ page as well which would be useful I think.

I'm going to close this issue and reference this one on the Hub:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants