Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support integer types other than BIGINT #484

Open
edgarrmondragon opened this issue Nov 27, 2024 · 0 comments · May be fixed by #485
Open

feat: Support integer types other than BIGINT #484

edgarrmondragon opened this issue Nov 27, 2024 · 0 comments · May be fixed by #485
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@edgarrmondragon
Copy link
Member

Description

Use JSON schema hints to determine the appropriate integer column type.

It's not currently supported. It can be done by updating this line:

to_sql.register_type_handler("integer", BIGINT)

to use a function that checks for certain JSON schema metadata to decide what type of int column to return. I'll log an issue in the GH repo later, unless you beat me to it.

Links:

@edgarrmondragon edgarrmondragon self-assigned this Nov 27, 2024
@edgarrmondragon edgarrmondragon added the enhancement New feature or request label Nov 27, 2024
@edgarrmondragon edgarrmondragon linked a pull request Nov 27, 2024 that will close this issue
2 tasks
@edgarrmondragon edgarrmondragon moved this to In Progress in MeltanoLabs Overview Nov 27, 2024
@edgarrmondragon edgarrmondragon added this to the v0.2.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant