Skip to content

Commit 3c094b0

Browse files
Merge pull request #492 from jdblischak/getfromnamespace
Use getFromNamespace instead of ::: to fix S3 dispatch for as_gt()
2 parents cbc103e + 7b7bc57 commit 3c094b0

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

R/as_gt.R

+2-1
Original file line numberDiff line numberDiff line change
@@ -421,5 +421,6 @@ gsd_parts <- function(
421421

422422
#' @export
423423
as_gt.simtrial_gs_wlr <- function(x, ...) {
424-
simtrial:::as_gt.simtrial_gs_wlr(x, ...)
424+
f <- utils::getFromNamespace("as_gt.simtrial_gs_wlr", "simtrial")
425+
f(x, ...)
425426
}

cran-comments.md

-19
Original file line numberDiff line numberDiff line change
@@ -1,19 +0,0 @@
1-
# gsDesign2 1.1.3
2-
3-
We are aware of the following NOTE, and we also maintain {simtrial}:
4-
5-
```
6-
* checking dependencies in R code ... NOTE
7-
Missing object imported by a ':::' call: ‘simtrial:::as_gt.simtrial_gs_wlr’
8-
```
9-
10-
11-
# gsDesign2 1.0.7
12-
13-
## Resubmission
14-
15-
This is a resubmission. In this version I have:
16-
17-
* Exported the internal functions to avoid the use of ::: in code examples.
18-
19-
* Fixed the write path issue by moving the test fixture generation script to data-raw/ which is not included in the package.

0 commit comments

Comments
 (0)