-
Notifications
You must be signed in to change notification settings - Fork 8
Add contributing guide with overview of package architecture #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
yihui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks!
.github/CONTRIBUTING.md
Outdated
|
|
||
| * The type of design is specified by the class of the object: `"fixed_design"` | ||
| or `"gs_design"` | ||
| * The method for testing is specified by the list element `design`, which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why we named this element design originally instead of method or test. Maybe this is more of a question for @LittleBeannie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought. It made it difficult to write this documentation when in one sentence "design" refers to "fixed versus group sequential" and the next sentence it refers to the test method
nanxstats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks great! Simple to comprehend.
Since this is a "design doc" document, should we put it as a vignette or article? I mean, CONTRIBUTING.md is often used to document logistical aspects of how to make contributions, not the technical design of the package itself.
Thanks!
I'm fine with whatever we decide on. My thinking is that this information is mainly of interest to developers and less so to end users. The technical overview of the package architecture serves as the introduction/context to the explanation of the logistical aspects of making a contribution (e.g. when to use |
|
As discussed in group meeting, I moved the content to an article to be displayed on the pkgdown website |
I added a
CONTRIBUTING.mdthat provides an overview of how we store the various clinical trial design characteristics in our R objects.xref: #457, #584
I didn't add a diagram of the class hierarchy because it is so flat. Each of our S3 methods only dispatches to two possible classes, and there is no inheritance between classes. Of course I'm open to ideas on how to create an informative diagram.
gsDesign2/NAMESPACE
Lines 3 to 13 in 9098bde