Merge pull request rails#54699 from byroot/result-dup

Fix `ActiveRecord::Result#dup` consistency

Author: byroot

activerecord/lib/active_record/result.rb

@@ -208,7 +208,6 @@ def cast_values(type_overrides = nil) # :nodoc:
 
     def initialize_copy(other)
       @rows = rows.dup
-      @column_types = column_types.dup
       @hash_rows    = nil
     end
 
@@ -239,6 +238,11 @@ def indexed_rows # :nodoc:
       end
     end
 
+    protected
+      def raw_column_types
+        @column_types
+      end
+
     private
       def column_type(name, index, type_overrides)
         if type_overrides

activerecord/test/cases/result_test.rb

@@ -129,5 +129,23 @@ def result
         assert_equal "col 2", row["foo"]
       end
     end
+
+    test "dup preserve all attributes" do
+      a = result
+      b = a.dup
+
+      assert_equal a.column_types, b.column_types
+      assert_equal a.columns, b.columns
+      assert_equal a.rows, b.rows
+      assert_equal a.column_indexes, b.column_indexes
+
+      # Second round in case of mutation
+      b = b.dup
+
+      assert_equal a.column_types, b.column_types
+      assert_equal a.columns, b.columns
+      assert_equal a.rows, b.rows
+      assert_equal a.column_indexes, b.column_indexes
+    end
   end
 end