get_largest_cros_blockdev fails in pre-frecon shims

[ZeglolTheThirtySixth]

On all devices i've tested that are pre-frecon, get_largest_cros_blockdev completely fails, and every action that uses it (cryptosmite, disabling rootfs verification, touching .developer_mode, etc) exits complaining about the internal storage not having a ChromeOS install.

This has mostly been tested on Kefka, and I have not encountered this error when running a frecon shim (e.g. octopus, legacy sh1mmer doesn't change anything), and I'm not entirely sure what the cause is as I haven't done much testing, though if I had to guess it's likely an outdated or missing binary for sfdisk.

[BinBashBanana]

Can you send the output of sfdisk -l -o name /dev/mmcblk0

[ZeglolTheThirtySixth]

I was right, running sfdisk with those arguments shows "invalid option -- 'o'" and the rest of the sfdisk help menu. This was tested on the shim and in a chroot for the screenshot.

[DJ-Laser]

This seems to work in the coral shim, sfdisk lists the -o option in the help menu, but I haven't tested any of the payloads. I'll try to cryptosmite a hana Chromebook soon, I'll comment the results here.

[BinBashBanana]

should be resolved now :D

[ZeglolTheThirtySixth]

@BinBashBanana Tested on latest commit, the issue still persists with all usages of get_largest_cros_blockdev continuining to return "No CrOS SSD found on device!"

[BinBashBanana]

Is ChromeOS installed on the internal drive? It won't find it without. If it is, can you send the output of sfdisk -d /dev/mmcblk0

[ZeglolTheThirtySixth]

localhost / # sfdisk -d /dev/mmcblk0
# partition table of /dev/mmcblk0
unit: sectors

/dev/mmcblk0p1 : start=          1, size= 61071359, Id=ee
/dev/mmcblk0p2 : start=          0, size=               0, Id= 0
/dev/mmcblk0p3 : start=          0, size=               0, Id= 0
/dev/mmcblk0p4 : start=          0, size=               0, Id= 0

@BinBashBanana
A full stock ChromeOS is installed on the internal drive

[BinBashBanana]

Uh oh... looks like sfdisk didn't used to support GPT. I'll have to use cgpt instead.

[yalelhoel]

confirmed on octopus, attempted to use a legacy shim all i was greeted with when trying to use pretty much every option was, something complaining about no chromeos install

[ZeglolTheThirtySixth]

I don't think octopus is affected by this issue as its shim was made at R72, the main device i've done my testing on is kefka, which was made for R48, the function relies on the presence of a ChromeOS install on the disk so if you didn't have one it won't work either way.

[yalelhoel]

i do have a chromeos install, it may just be that i frankensteined this shim together but from what i see, i have all dependencies

[yalelhoel]

yeah no, it just doesn't work, and for seemingly no reason

[BinBashBanana]

You need ChromeOS installed on the disk for it to work.

[BinBashBanana]

Misread, can you send the output of sfdisk -l /dev/mmcblk0

[BinBashBanana]

@ZeglolTheThirtySixth static sfdisk will be bundled instead, as there are other functions that rely on sfdisk as well.

[yalelhoel]

as i said, chromeos is installed

[yalelhoel]

dont have access to the computer rn

[yalelhoel]

got the computer, it does indeed have chromeos installed on the mmc card in the chromebook it is in fact booted into chromeos currently