Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad behavior of GEODIFF_createRebasedChangesetEx if one input changeset is empty #209

Open
wonder-sk opened this issue Feb 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

If one of the input diffs to GEODIFF_createRebasedChangesetEx() is empty, the file copy does a wrong thing:

https://github.com/MerginMaps/geodiff/blob/master/geodiff/src/geodiffrebase.cpp#L623

filecopy() has order of arguments 1. to, 2. from, but the code uses the opposite direction.

A regression from cf32f8a where boost::filesystem::copy() uses order of arguments 1. from, 2. to

Fortunately this should not affect ordinary mobile app / plugin users, as those call GEODIFF_rebase() which exists early if one of the input diffs is empty, without doing rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant