Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or replace "*" in activationEvents #31

Open
hmnd opened this issue Aug 9, 2021 · 0 comments
Open

Remove or replace "*" in activationEvents #31

hmnd opened this issue Aug 9, 2021 · 0 comments

Comments

@hmnd
Copy link

hmnd commented Aug 9, 2021

Problem
Currently, this extension runs on any project, even if that project doesn't use openapi. This unnecessarily adds ~950ms to activation time in some of my larger projects, even though they don't use openapi.

Solution
I know this extension contributes validation schemas and has some commands, but I'm not sure of the full scope of what it does.
If this extension doesn't do anything beyond the validation schemas and commands, I believe the "*" event in package.json's acitvationEvents can be removed entirely.
Otherwise, it could be replaced with specific events, similar to "workspaceContains:**/*swagger.json".

@hmnd hmnd changed the title Replace "*" in activationEvents Remove or replace "*" in activationEvents Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant