Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better PIP integration #22

Open
xavdid opened this issue Nov 25, 2016 · 6 comments
Open

Better PIP integration #22

xavdid opened this issue Nov 25, 2016 · 6 comments

Comments

@xavdid
Copy link

xavdid commented Nov 25, 2016

Hey! Love they app, really cool code you've got going.

My biggest suggestion is twofold-

  1. Include a requirements file. It'll help people install the right deps on the first try (for instance, on mac you need to install pyxdg instead of xdg when using pip).

  2. Be able to install this package via pip instead of cloning. This is a fairly straightforward process. More info can be found here.

I'm happy to make a PR for the first, though I'm not sure if you need certain versions or anything.

@MestreLion
Copy link
Owner

Thanks for the compliments! Glad it's been useful for many people :)

  1. That would be very welcome... and If I recall correctly, DistUtils (or SetupTools) already has a standard for a requirements file, so if you could follow such standard it would be great! Please use the lowest possible versions for the requirements, to make the project as compatible as it can (hint: the versions that ships with Ubuntu 12.04 are fine)

  2. Yeah, this is very needed indeed, it's actually one of my main "To-Do" items in the README. But I think it requires a setup.py and possibly more, and I have zero experience in setting up a setup :)

Go ahead, green light for the PRs! I will gladly merge them!

@drakenation
Copy link

drakenation commented Sep 28, 2017

I cloned the repository and am currently working on this. However, some changes needed to be made. The name 'humblebundle' is forbidden in PyPI, so I renamed the app to 'humblelion'. I also changed the version from '0.0.0' to '0.0.2'.

You can already install it with

pip install humblelion

Seems to be somewhat working. I reached the point where the issue #33, the login failure, prevented me from continuing.
Bear in mind, however, that I'm also porting to python3, so python2 compatibility is broken for now.

@MestreLion
Copy link
Owner

@drakenation , I just tagged a new release, should be Python3 compatible by now, care to check and re-try the PIP integration? Once again, thanks a LOT for making this happen!

@beargeek
Copy link

beargeek commented Mar 6, 2018

@drakenation I did a pip install for humblelion and I'm getting this:

734 CRITICAL ('Could not retrieve token: %r', AttributeError("'NoneType' object has no attribute 'groups'",))

@MestreLion
Copy link
Owner

@beargeek, care to paste the whole error messages, including the stack trace?

@beargeek
Copy link

beargeek commented Mar 7, 2018

@MestreLion this is all I got. Not sure how to get a stacktrace:

computer:bin me$ humblelion --update --debug 2018-03-07 10:07:00,680 DEBUG Namespace(arch=None, auth=None, bittorrent=False, clear=False, code=None, debug=True, download=None, install=None, json=False, list=None, list_bundles=False, loglevel='debug', method=None, password=None, path=None, platform='linux', serverfile=None, show=None, show_bundle=None, type=None, uninstall=None, update=True, username=None) 2018-03-07 10:07:00,681 DEBUG Reading credentials from keyring 2018-03-07 10:07:00,703 INFO Retrieving keys from 'https://www.humblebundle.com/home/keys' send: b'GET /home/keys HTTP/1.1\r\nAccept-Encoding: identity\r\nHost: www.humblebundle.com\r\nUser-Agent: Python-urllib/3.6\r\nCookie: _simpleauth_sess="xxx\\075\\075|xxx|xxxxx"; csrf_cookie=xxxxx\r\nConnection: close\r\n\r\n' reply: 'HTTP/1.1 302 Found\r\n' header: Content-Type header: Cache-Control header: Set-Cookie header: Location header: X-Cloud-Trace-Context header: Date header: Server header: Content-Length header: Connection send: b'GET /login?goto=%2Fhome%2Fkeys HTTP/1.1\r\nAccept-Encoding: identity\r\nHost: www.humblebundle.com\r\nUser-Agent: Python-urllib/3.6\r\nCookie: _simpleauth_sess="xxxxx; hbflash=You%20must%20sign%20in.\r\nConnection: close\r\n\r\n' reply: 'HTTP/1.1 200 OK\r\n' 2018-03-07 10:07:01,037 INFO Authenticating at 'https://www.humblebundle.com/processlogin' 2018-03-07 10:07:01,071 CRITICAL ('Could not retrieve token: %r', AttributeError("'NoneType' object has no attribute 'groups'",)) header: Content-Type header: Cache-Control header: X-Cloud-Trace-Context header: Date header: Server header: Content-Length header: Connection

I think it might have something to do with this: hbflash=You%20must%20sign%20in.\r\nConnection: close\r\n\r\n'

((xxxx's are redacted information))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants