Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constraints tests more robust #838

Open
jfrost-mo opened this issue Sep 17, 2024 · 0 comments
Open

Make constraints tests more robust #838

jfrost-mo opened this issue Sep 17, 2024 · 0 comments
Labels
cleanup Non-functional improvement good first issue Good for newcomers

Comments

@jfrost-mo
Copy link
Member

jfrost-mo commented Sep 17, 2024 •
edited
Loading

I don't think checking the result of repr is sufficient for many of the tests in this file. In particular those where the repr just says a lambda or function. The relevant lambda or function could be changed to something that produces complete nonsense and these tests would never catch it. It's not really related to this PR though so I'd suggest opening a new issue.

Originally posted by @SGallagherMet in #765 (comment)

We should make the tests in test_constraints.py more robust. This will likely involve making most of them into filter tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Non-functional improvement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfrost-mo