remove unused vars

Author: mikesposito

eslint-warning-thresholds.json

@@ -213,10 +213,10 @@
   },
   "packages/keyring-controller/src/KeyringController.test.ts": {
     "import-x/namespace": 14,
-    "jest/no-conditional-in-test": 8
+    "jest/no-conditional-in-test": 7
   },
   "packages/keyring-controller/src/KeyringController.ts": {
-    "@typescript-eslint/no-unsafe-enum-comparison": 4,
+    "@typescript-eslint/no-unsafe-enum-comparison": 3,
     "@typescript-eslint/no-unused-vars": 1
   },
   "packages/keyring-controller/tests/mocks/mockKeyring.ts": {
@@ -260,7 +260,6 @@
     "import-x/order": 1
   },
   "packages/multichain/src/adapters/caip-permission-adapter-eth-accounts.ts": {
-    "@typescript-eslint/no-unsafe-enum-comparison": 1,
     "jsdoc/tag-lines": 5
   },
   "packages/multichain/src/adapters/caip-permission-adapter-permittedChains.test.ts": {
@@ -325,7 +324,7 @@
     "jsdoc/require-returns": 1
   },
   "packages/multichain/src/scope/supported.ts": {
-    "@typescript-eslint/no-unsafe-enum-comparison": 6
+    "@typescript-eslint/no-unsafe-enum-comparison": 3
   },
   "packages/multichain/src/scope/validation.ts": {
     "jsdoc/tag-lines": 2

packages/keyring-controller/src/KeyringController.test.ts

@@ -2511,11 +2511,9 @@ describe('KeyringController', () => {
       await withController(async ({ controller, encryptor }) => {
         const newPassword = 'new-password';
         const keyFromPasswordSpy = jest.spyOn(encryptor, 'keyFromPassword');
-        const spiedEncryptionFn = jest.spyOn(encryptor, 'encryptWithKey');
 
         await controller.changePassword(newPassword);
 
-        // we pick the first argument of the first call
         expect(keyFromPasswordSpy).toHaveBeenCalledWith(
           newPassword,
           controller.state.encryptionSalt,
@@ -3022,7 +3020,7 @@ describe('KeyringController', () => {
     });
 
     it('should throw error if vault unlocked has an unexpected shape', async () => {
-      await withController(async ({ controller, initialState, encryptor }) => {
+      await withController(async ({ controller, encryptor }) => {
         jest.spyOn(encryptor, 'decryptWithKey').mockResolvedValueOnce([
           {
             foo: 'bar',
@@ -3036,7 +3034,7 @@ describe('KeyringController', () => {
     });
 
     it('should throw error if encryptionKey is of an unexpected type', async () => {
-      await withController(async ({ controller, initialState }) => {
+      await withController(async ({ controller }) => {
         await expect(
           controller.submitEncryptionKey(
             // @ts-expect-error we are testing the case of a user using

packages/keyring-controller/src/constants.ts

@@ -3,7 +3,7 @@ export enum KeyringControllerError {
   KeyringNotFound = 'KeyringController - Keyring not found.',
   UnsafeDirectKeyringAccess = 'KeyringController - Returning keyring instances is unsafe',
   WrongPasswordType = 'KeyringController - Password must be of type string.',
-  WrongEncryptionKeyType = 'KeyringController - Password must be of type string.',
+  WrongEncryptionKeyType = 'KeyringController - Encryption key must be of type string.',
   InvalidEmptyPassword = 'KeyringController - Password cannot be empty.',
   NoFirstAccount = 'KeyringController - First Account not found.',
   DuplicatedAccount = 'KeyringController - The account you are trying to import is a duplicate',

packages/keyring-controller/tests/mocks/mockEncryptor.ts

@@ -64,7 +64,7 @@ export default class MockEncryptor implements ExportableKeyEncryptor {
     };
   }
 
-  async decryptWithKey(key: unknown, text: string) {
+  async decryptWithKey(_key: unknown, _text: string) {
     return JSON.parse(this.cacheVal || '') ?? {};
   }