Skip to content

Commit fa811f9

Browse files
authored
chore: Disable ESLint cache by default (#7082)
## Explanation The ESLint cache feature has known problems with lint rules that depend upon multiple files, such as type-related rules. See here for more on why it's not advised: https://typescript-eslint.io/troubleshooting/faqs/eslint/#can-i-use-eslints---cache-with-typescript-eslint ## References N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes ESLint caching from root and package lint scripts to avoid cache-related issues. > > - **Linting**: > - Disable ESLint cache in root `package.json` by removing `--cache` from `lint:eslint` (runs `./scripts/run-eslint.ts`). > - Disable ESLint cache in package lint scripts by removing `--cache` from `eslint` invocations in: > - `packages/eth-block-tracker/package.json` > - `packages/eth-json-rpc-middleware/package.json` > - `packages/eth-json-rpc-provider/package.json` > - `packages/json-rpc-engine/package.json` > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 28ee04d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 5deeabf commit fa811f9

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn generate-method-action-types --check",
2626
"lint:dependencies": "depcheck && yarn dedupe --check",
2727
"lint:dependencies:fix": "depcheck && yarn dedupe",
28-
"lint:eslint": "yarn build:only-clean && yarn tsx ./scripts/run-eslint.ts --cache",
28+
"lint:eslint": "yarn build:only-clean && yarn tsx ./scripts/run-eslint.ts ",
2929
"lint:fix": "yarn lint:eslint --fix && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn generate-method-action-types --fix",
3030
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore",
3131
"lint:teams": "tsx scripts/lint-teams-json.ts",

packages/eth-block-tracker/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/eth-block-tracker",
4545
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:dependencies",
4646
"lint:dependencies": "depcheck",
47-
"lint:eslint": "eslint . --cache --ext js,ts",
47+
"lint:eslint": "eslint . --ext js,ts",
4848
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies",
4949
"lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",
5050
"publish:preview": "yarn npm publish --tag preview",

packages/eth-json-rpc-middleware/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:dependencies && yarn lint:changelog",
4545
"lint:changelog": "auto-changelog validate",
4646
"lint:dependencies": "depcheck",
47-
"lint:eslint": "eslint . --cache --ext js,ts",
47+
"lint:eslint": "eslint . --ext js,ts",
4848
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies && yarn lint:changelog",
4949
"lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",
5050
"publish:preview": "yarn npm publish --tag preview",

packages/eth-json-rpc-provider/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/eth-json-rpc-provider",
4343
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:dependencies",
4444
"lint:dependencies": "depcheck",
45-
"lint:eslint": "eslint . --cache --ext js,ts",
45+
"lint:eslint": "eslint . --ext js,ts",
4646
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies",
4747
"lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",
4848
"publish:preview": "yarn npm publish --tag preview",

packages/json-rpc-engine/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:dependencies && yarn lint:changelog",
5858
"lint:changelog": "auto-changelog validate",
5959
"lint:dependencies": "depcheck",
60-
"lint:eslint": "eslint . --cache --ext js,ts",
60+
"lint:eslint": "eslint . --ext js,ts",
6161
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies && yarn lint:changelog",
6262
"lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",
6363
"publish:preview": "yarn npm publish --tag preview",

0 commit comments

Comments
 (0)