From 8a87315002d2b266e281bf869abb61cad643ba32 Mon Sep 17 00:00:00 2001 From: David Walsh Date: Wed, 13 Nov 2024 14:00:13 -0600 Subject: [PATCH] fix: Update PortfolioView flag (#28446) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Provides a more descriptive feature flag name [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28446?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- builds.yml | 4 ++-- .../asset-list-control-bar/asset-list-control-bar.tsx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/builds.yml b/builds.yml index 2442ad51475a..d60365f8bc5a 100644 --- a/builds.yml +++ b/builds.yml @@ -280,8 +280,8 @@ env: - BARAD_DUR: '' # Determines if feature flagged Chain permissions - CHAIN_PERMISSIONS: '' - # Determines if feature flagged Filter toggle - - FILTER_TOKENS_TOGGLE: '' + # Determines if Portfolio View UI should be shown + - PORTFOLIO_VIEW: '' # Enables use of test gas fee flow to debug gas fee estimation - TEST_GAS_FEE_FLOWS: false # Temporary mechanism to enable security alerts API prior to release diff --git a/ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx b/ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx index de771976e677..c09421279265 100644 --- a/ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx +++ b/ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx @@ -78,7 +78,7 @@ const AssetListControlBar = ({ showTokensLinks }: AssetListControlBarProps) => { isFullScreen ? JustifyContent.flexStart : JustifyContent.spaceBetween } > - {process.env.FILTER_TOKENS_TOGGLE && ( + {process.env.PORTFOLIO_VIEW && (