-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Simulation metrics not captured in the wallet initiated Redesigned Confirmation Send Flow #28369
Comments
hello @sleepytanya! I think the bug is that the simulation is expected to work in the redesign as it is shown in the old confirmation pages using the same flow. we can observe no "Estimated Changes" section in the redesign here: For now, I will unassign myself and put this back into refine status to re-refine next week & updated the title from: |
@digiwand could we still capture the simulation data even if we don't display it to the user? Alternatively, we can display it under advanced view only, but capture the simulation data for both users with advanced view on and users that have it off. Asking as the send flow is also important for the same leadership ask around metrics. |
hello @bschorchit 👋🏼 we could. What I would suggest or question is how we'd distinguish between no results returned vs. not showing the simulation. (I'm not exactly sure of the UI/UX behavior here as I'm writing this.) Updating metrics to indicate whether the user has seen or has not seen the simulation rendered in the advanced view could be a different feature request |
That's a good point. I think we could infer if the user has seen simulations or not from other properties like: With that we can build a dashboard or even custom property directly on Mixpanel to indicate to us whether the simulations UI was visible to users at transaction time. |
I've updated the issue post discussion on slack. This continues to be a release blocker for the reasons mentioned earlier above.
|
Describe the bug
The properties
simulations_sending_assets_total_value
,simulations_receiving_assets_total_value
andtransaction_contract_method
are intended to be present in both Anonymous and non-Anonymous events. However, these simulation metrics are not presented for wallet initiated redesigned send flow.Expected behavior
For a given transaction, we should see the same simulations metrics when doing it with the improved transactions toggle on and when doing it with the improved transactions toggle off.
Simulations metrics should be capture even when the simulation UI is not visible (only exception is if the user had disabled it themselves).
Screenshots/Recordings
Experimental
andDeveloper
toggles are ON - simulations metrics are not present:redesignOn.mov
Experimental
andDeveloper
toggles are OFF - simulation metrics are in Anon- and non-Anon events:redesignOff.mov
Steps to reproduce
Experimental
andDeveloper
toggles ONTransaction Approved
andTransaction Approved Anon
events in the SegmentError messages or log output
No response
Detection stage
During release testing
Version
12.7.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: