test: fix flaky erc20 send token e2e #28775

pnarayanaswamy · 2024-11-27T14:33:32Z

Description

The issue is that sometimes when clicking on the watchAssets button from the test dapp the metamask dialog does not open. The test dapp button is present and enabled but for some reason clicking on it does nothing. However if you wait for a second and then click this seems to solve the issue.

Also tried to wait until the page is loaded, element is present, visible and enabled, however, the flakiness persists. Hence added a hardcoded wait.

Related issues

Fixes: #28700

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-27T14:33:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-27T15:34:58Z

Builds ready [41e5b22]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1827 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	357	2100	1754	358	172
		domContentLoaded	1531	2080	1785	149	72
		load	1575	2099	1827	159	77
		domInteractive	26	73	41	15	7
		backgroundConnect	7	87	44	26	12
		firstReactRender	17	77	31	20	10
		getState	5	60	18	18	9
		initialActions	0	1	0	0	0
		loadScripts	1087	1549	1308	138	66
		setupStore	6	54	11	10	5
		uiStartup	1731	2794	2051	240	115

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-28T07:31:50Z

Builds ready [a005cfa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1799 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1620	1980	1804	94	45
		domContentLoaded	1605	1938	1774	93	45
		load	1618	1982	1799	97	47
		domInteractive	23	97	41	24	12
		backgroundConnect	9	47	21	13	6
		firstReactRender	15	89	23	17	8
		getState	45	205	87	33	16
		initialActions	0	1	0	0	0
		loadScripts	1232	1504	1367	82	39
		setupStore	6	10	7	1	1
		uiStartup	1817	2402	2042	141	68

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-28T10:50:09Z

Builds ready [aaa11aa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1814 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	309	2008	1745	348	167
		domContentLoaded	1504	1938	1798	105	51
		load	1513	1956	1814	110	53
		domInteractive	26	63	37	13	6
		backgroundConnect	7	37	14	7	3
		firstReactRender	16	89	27	21	10
		getState	52	104	91	12	6
		initialActions	0	1	0	0	0
		loadScripts	1089	1535	1381	105	50
		setupStore	6	51	10	9	5
		uiStartup	1726	2253	2063	124	60

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-02T09:24:05Z

Builds ready [a0f03c6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1810 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	620	2139	1718	287	138
		domContentLoaded	1474	2519	1790	216	104
		load	1491	2538	1810	217	104
		domInteractive	24	49	30	7	3
		backgroundConnect	7	66	23	17	8
		firstReactRender	15	99	27	23	11
		getState	47	212	99	32	16
		initialActions	0	0	0	0	0
		loadScripts	1058	1997	1341	200	96
		setupStore	6	80	14	19	9
		uiStartup	1715	2930	2107	288	138

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-05T18:47:57Z

Builds ready [3e808a3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1929 ± 141 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1629	2593	1937	292	140
		domContentLoaded	1585	2526	1904	291	140
		load	1593	2564	1929	294	141
		domInteractive	25	92	43	21	10
		backgroundConnect	8	72	28	18	9
		firstReactRender	15	105	31	27	13
		getState	84	392	152	77	37
		initialActions	0	1	0	0	0
		loadScripts	1213	1944	1460	223	107
		setupStore	6	80	15	22	10
		uiStartup	1786	3583	2300	513	246

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test: fix flaky erc20 send token e2e

ba2e562

pnarayanaswamy requested a review from a team as a code owner November 27, 2024 14:33

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 27, 2024

Merge branch 'develop' into fix-erc20-e2e

41e5b22

Merge branch 'develop' into fix-erc20-e2e

a005cfa

Merge branch 'develop' into fix-erc20-e2e

aaa11aa

Merge branch 'develop' into fix-erc20-e2e

a0f03c6

cryptotavares requested a review from a team December 4, 2024 13:55

OGPoyraz approved these changes Dec 4, 2024

View reviewed changes

hjetpoluru approved these changes Dec 5, 2024

View reviewed changes

hjetpoluru added this pull request to the merge queue Dec 5, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024

Merge branch 'main' into fix-erc20-e2e

3e808a3

hjetpoluru added this pull request to the merge queue Dec 5, 2024

Merged via the queue into main with commit 456e63f Dec 5, 2024
75 checks passed

hjetpoluru deleted the fix-erc20-e2e branch December 5, 2024 20:29

github-actions bot locked and limited conversation to collaborators Dec 5, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix flaky erc20 send token e2e #28775

test: fix flaky erc20 send token e2e #28775

pnarayanaswamy commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Dec 2, 2024

metamaskbot commented Dec 5, 2024

test: fix flaky erc20 send token e2e #28775

test: fix flaky erc20 send token e2e #28775

Conversation

pnarayanaswamy commented Nov 27, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Dec 2, 2024

metamaskbot commented Dec 5, 2024

pnarayanaswamy commented Nov 27, 2024 •

edited

Loading