Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamsk/network-controller to 21.0.1 #28824

Closed
wants to merge 2 commits into from

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 29, 2024

Description

This PR bumps @metamsk/network-controller to 21.0.1

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s self-assigned this Nov 29, 2024
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner November 29, 2024 19:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-network-controller-21.0.1 branch from 74f1bc1 to c7108fd Compare November 29, 2024 19:42
@metamaskbot
Copy link
Collaborator

Builds ready [ec5cd0b]
Page Load Metrics (1985 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint157826921994293141
domContentLoaded157226321960286138
load162626431985282135
domInteractive23135392412
backgroundConnect690282412
firstReactRender156624147
getState2596672412
initialActions01000
loadScripts114220371490224107
setupStore66816199
uiStartup182830222271325156
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 6 Bytes (0.00%)
  • ui: 5 Bytes (0.00%)
  • common: -704 Bytes (-0.01%)

@Gudahtt
Copy link
Member

Gudahtt commented Dec 3, 2024

Shall we close this, and bump network-controller to the latest patch in the other PR?

@cryptodev-2s
Copy link
Contributor Author

Shall we close this, and bump network-controller to the latest patch in the other PR?

Yes make sense

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@cryptodev-2s
Copy link
Contributor Author

The network controller will be bumped in #28781

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants