Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: foundryup unit #28833

Open
wants to merge 6 commits into
base: foundryup
Choose a base branch
from
Open

test: foundryup unit #28833

wants to merge 6 commits into from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Dec 2, 2024

Description

  • Splits the logic of foundryup.ts file into functions, so they are easier to test
  • Adds unit tests
  • Updates file extensions from mts to ts. The reason for that is because otherwise the unit tests don't run out of the box and it was suggested to change the config file and add a new dependency to make it work, which seems unnecessary for the scoped task of installing foundry.

The unit tests can be run with yarn test:unit test/helpers/foundry/foundryup.test.ts

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Run: yarn test:unit test/helpers/foundry/foundryup.test.ts

Screenshots/Recordings

Screenshot from 2024-12-10 11-47-37

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [9249f37]
Page Load Metrics (1820 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint154625521820228109
domContentLoaded154024421789213102
load154725561820227109
domInteractive237635167
backgroundConnect8113332914
firstReactRender1591322512
getState44199984722
initialActions01000
loadScripts11641616135813967
setupStore67012147
uiStartup174228722127290139
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [77c7b94]
Page Load Metrics (2026 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24521991735621298
domContentLoaded17682473197316981
load18002547202618086
domInteractive256332105
backgroundConnect10245534923
firstReactRender169123168
getState824041628742
initialActions01000
loadScripts13541943151914670
setupStore78013168
uiStartup203129902374304146
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona marked this pull request as ready for review December 10, 2024 10:48
@seaona seaona requested a review from a team as a code owner December 10, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants