fix: patch authentication controller sign out validation

[Prithpal-Sooriya]

Description

This adds a patch (fix from this PR: MetaMask/core#5013), to remove the state validation from signing out. This is because the Authentication State could be either in a weird state, or metametrics toggle does not behave and use the 'signedIn' property from authentication.

Either way, this ensures that signing out using the Authentication Controller works correctly and does not throw any errors.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3709

Manual testing steps

I have not been able to find repro-steps from this issue. However the below should still work

Onboarding

1. Select a new or existing wallet
2. Enable metametrics
3. Continue onboarding - EXPECTED: should succeed without issues

Settings page

1. Navigate to settings > advanced
2. Toggle metametrics on/off - EXPECTED: should see the switch enable/disable without errors.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	0	132 kB	alex3165

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@stablelib/[email protected], npm/@stablelib/[email protected], npm/@stablelib/[email protected], npm/@stablelib/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
New author	npm/[email protected]	New Author: alex3165 Previous Author: ellbee	package.json yarn.lock	🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]

[metamaskbot]

Builds ready [da1ccd4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1737 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1503	2144	1743	164	79
		domContentLoaded	1497	2088	1704	154	74
		load	1502	2102	1737	162	78
		domInteractive	23	133	41	27	13
		backgroundConnect	7	72	34	22	11
		firstReactRender	14	56	27	14	7
		getState	47	103	74	21	10
		initialActions	0	1	0	0	0
		loadScripts	1106	1681	1306	142	68
		setupStore	6	55	12	11	6
		uiStartup	1760	2440	1967	176	85

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: -27 Bytes (-0.00%)

[Prithpal-Sooriya]

Patched until profile-sync-controller changes are released.

The next upgrade of this package has an interdependency with the network controller.

[Prithpal-Sooriya]

Closing this as @mathieuartu fix is more ideal than package patching.