Skip to content

Commit

Permalink
fix: Fix copy of "Network fee" on approval (#12370)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR make send confirmation to use "Network fee" instead of
"Estimated gas fee"

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3611

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
OGPoyraz authored Nov 21, 2024
1 parent 800c188 commit eb42a68
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,7 @@ exports[`Confirm should render correctly 1`] = `
]
}
>
Estimated gas fee
Network fee
<TouchableOpacity
hitSlop={
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ exports[`TransactionReviewEIP1559 should render correctly 1`] = `
]
}
>
Estimated gas fee
Network fee
<TouchableOpacity
hitSlop={
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const TransactionReviewEIP1559Update = ({
onEdit,
hideTotal,
noMargin,
origin,
originWarning,
onUpdatingValuesStart,
onUpdatingValuesEnd,
Expand Down Expand Up @@ -129,9 +128,7 @@ const TransactionReviewEIP1559Update = ({
orange={Boolean(originWarning)}
noMargin
>
{!origin
? strings('transaction_review_eip1559.estimated_gas_fee')
: strings('transaction_review_eip1559.network_fee')}
{strings('transaction_review_eip1559.network_fee')}
<TouchableOpacity
style={styles.gasInfoContainer}
onPress={() =>
Expand Down

0 comments on commit eb42a68

Please sign in to comment.