chore: Cherry pick 2506358 (merge in trackEvent work) #12415
Merged
+3,368
−2,511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> > [!IMPORTANT] > The issue is due to the fact that `MetaMetrics.trackEvent` method has multiple signatures to handle the backward compatibility with old ways to call it. > After discussion (see the change history of this description), we decided to remove backward compatibility and the multiple signature system. We are going to simplify and then fix all the `trackEvent` calls. Asside from the changes in `MetaMetrics` and `useMetrics` hook (and tests) all the changes should be on the calls of `trackEvent`. - removes multiple signature `MetaMetrics.trackEvent` - updates `MetaMetrics` unit tests - updates `useMetrics` hook - updates `useMetrics` hook unit tests - deletes now useless legacy compatibility utils - updates all `trackEvent` calls - updates all unit tests that test `trackEvent` calls Fixes #12117 1. navigate the app 2. check trackEvent is called (check app logs) https://github.com/user-attachments/assets/058f6607-eda1-4eb5-bcae-a774deb13648 https://github.com/user-attachments/assets/fa0816cf-5459-4825-a162-a9a2e87c86ac N/A N/A - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Frank von Hoven <[email protected]> Co-authored-by: Frank von Hoven <[email protected]>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
sethkfman
added
the
skip-sonar-cloud
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The issue is due to the fact that
MetaMetrics.trackEventmethod hasmultiple signatures to handle the backward compatibility with old ways to call it.
After discussion (see the change history of this description), we
decided to remove backward compatibility and the multiple signature system. We are going to simplify and then fix all the
trackEventcalls.Asside from the changes in
MetaMetricsanduseMetricshook (and tests) all the changes should be on the calls oftrackEvent.MetaMetrics.trackEventMetaMetricsunit testsuseMetricshookuseMetricshook unit teststrackEventcallstrackEventcallsFixes #12117
events-1.mov
events-2.mov
N/A
N/A
I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding
Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist